[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] QemuOpt: add unit tests
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v4] QemuOpt: add unit tests |
Date: |
Tue, 20 May 2014 15:21:32 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, May 19, 2014 at 06:53:55PM -0300, Leandro Dorileo wrote:
> Cover basic aspects and API usage for QemuOpt. The current implementation
> covers the API's planned to be changed by Chunyan Liu in his
> QEMUOptionParameter
> replacement/cleanup job.
>
> Other APIs should be covered in future improvements.
>
> Signed-off-by: Leandro Dorileo <address@hidden>
> ---
>
> Notes:
> V4:
> + call register_opts() only once (pointed by Stefan);
>
> V3:
> + fix a typo (s/dinamically/dynamically/);
>
> V2:
> + fixed comments;
> + make use of g_assert_cmpstr();
> + use error_abort instead of a local_err for qemu_opts_absorb_qdict();
> + asserts on QemuOptsList (empty and list name);
> + added test_qemu_opt_unset();
> + asserts on qemu_opt_*_set() return;
> + added test_qemu_opts_reset();
> + added test_qemu_opts_set();
>
> tests/Makefile | 3 +
> tests/test-qemu-opts.c | 438
> +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 441 insertions(+)
> create mode 100644 tests/test-qemu-opts.c
Great, thanks for writing this test case. It's good to have this here
before applying Chunyan's patches.
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan