[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDr
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState |
Date: |
Wed, 21 May 2014 16:03:03 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, May 20, 2014 at 02:04:31PM +0800, Fam Zheng wrote:
> diff --git a/block/mirror.c b/block/mirror.c
> index 1c38aa8..6a53d79 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -499,6 +499,7 @@ immediate_exit:
> * trigger the unref from the top one */
> BlockDriverState *p = s->base->backing_hd;
> s->base->backing_hd = NULL;
> + bdrv_op_unblock_all(p, s->base->backing_blocker);
> bdrv_unref(p);
> }
> }
Would be cleaner to call bdrv_set_backing_hd(s->base, NULL) here instead
of open coding it.
Stefan
Re: [Qemu-devel] [PATCH v20 04/15] block: Move op_blocker check from block_job_create to its caller, Stefan Hajnoczi, 2014/05/21
[Qemu-devel] [PATCH v20 05/15] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 07/15] block: Parse "backing" option to reference existing BDS, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState, Fam Zheng, 2014/05/20
- Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState,
Stefan Hajnoczi <=
Re: [Qemu-devel] [PATCH v20 06/15] block: Add backing_blocker in BlockDriverState, Stefan Hajnoczi, 2014/05/21
[Qemu-devel] [PATCH v20 08/15] block: Support dropping active in bdrv_drop_intermediate, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 09/15] stream: Use bdrv_drop_intermediate and drop close_unused_images, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 10/15] commit: Use bdrv_drop_intermediate, Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 11/15] qmp: Add command 'blockdev-backup', Fam Zheng, 2014/05/20
[Qemu-devel] [PATCH v20 12/15] block: Allow backup on referenced named BlockDriverState, Fam Zheng, 2014/05/20