[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant cond
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional |
Date: |
Thu, 22 May 2014 16:57:22 +0200 |
Bailing out when PK11_FindGenericObjects() returns null ensures the
loop that follows it executes at least once. The "loop did not
execute" test right after it is useless. Drop it.
Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
libcacard/vcard_emul_nss.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
index 83b89e4..2ebe13f 100644
--- a/libcacard/vcard_emul_nss.c
+++ b/libcacard/vcard_emul_nss.c
@@ -618,11 +618,6 @@ vcard_emul_mirror_card(VReader *vreader)
cert_count++;
}
- if (cert_count == 0) {
- PK11_DestroyGenericObjects(firstObj);
- return NULL;
- }
-
/* allocate the arrays */
vcard_emul_alloc_arrays(&certs, &cert_len, &keys, cert_count);
--
1.9.0
- [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 4/7] libcacard/vreader: Tighten assertion to clarify intent, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional,
Markus Armbruster <=
- [Qemu-devel] [PATCH 5/7] libcacard: Convert two leftover realloc() to GLib, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 3/7] libcacard/vreader: Drop broken recovery from failed assertion, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null, Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 2/7] libcacard: Plug memory leaks around vreader_get_reader_list(), Markus Armbruster, 2014/05/22
- [Qemu-devel] [PATCH 1/7] libcacard/vscclient: Bury some dead code, Markus Armbruster, 2014/05/22
- Re: [Qemu-devel] [PATCH 0/7] libcacard: A few simple fixes and cleanups, Alon Levy, 2014/05/22