[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] w32: Fix regression caused by new g_poll implem
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] w32: Fix regression caused by new g_poll implementation |
Date: |
Fri, 23 May 2014 11:36:48 +0100 |
On 17 May 2014 09:34, Stefan Weil <address@hidden> wrote:
> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a
> performance degradation caused by bad handling of small timeouts
> in the original implementation of g_poll.
>
> Since that commit, hard disk I/O no longer works.
>
> Instead of rewriting the g_poll implementation, this patch simply copies
> the original code (released under LGPL) from latest glib and only modifies
> it where needed (see comments in the code). URL of the original code:
> https://git.gnome.org/browse/glib/tree/glib/gpoll.c
Oops, I didn't notice you'd done that. Our util/oslib-win32.c
file is marked as having a more liberal license than LGPL.
So we can't simply copy the LGPL code in without at least
adjusting the top-of-file comment to indicate which parts
of the file are LGPL and which are not.
thanks
-- PMM