[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanu
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups |
Date: |
Sat, 24 May 2014 00:54:12 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
23.05.2014 22:20, Michael Tokarev wrote:
> 23.05.2014 15:24, Markus Armbruster wrote:
>> Makes Coverity happy with libcacard/ (for now).
>>
>> v2:
>> - Fix g_new() vs. g_renew() mistake in PATCH 5 [Michael Tokarev]
>> - Trivially rebased
>
>> Markus Armbruster (7):
>> libcacard/vscclient: Bury some dead code
>> libcacard: Plug memory leaks around vreader_get_reader_list()
>> libcacard/vreader: Drop broken recovery from failed assertion
>> libcacard/vreader: Tighten assertion to clarify intent
>> libcacard: Convert two leftover realloc() to GLib
>> libcacard/vcard_emul_nss: Assert vreaderOpt isn't null
>> libcacard/vcard_emul_nss: Drop a redundant conditional
>
> Reviewed-by: Michael Tokarev <address@hidden>
>
> Except of the vreaderOpt assertion patch which I commented
> separately.
>
> I think this can easily go to the -trivial tree, as all the
> changes are really trivial. Including the bugfix, for which
> I can send a patch myself, again, as described in my previous
> reply.
I applied whole series to -trivial, except of this problematic
patch, for which I applied a real fix (will post in another
email).
Good stuff ;)
Thanks,
/mjt
- [Qemu-devel] [PATCH v2 6/7] libcacard/vcard_emul_nss: Assert vreaderOpt isn't null, (continued)
- [Qemu-devel] [PATCH v2 2/7] libcacard: Plug memory leaks around vreader_get_reader_list(), Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 3/7] libcacard/vreader: Drop broken recovery from failed assertion, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 7/7] libcacard/vcard_emul_nss: Drop a redundant conditional, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 1/7] libcacard/vscclient: Bury some dead code, Markus Armbruster, 2014/05/23
- [Qemu-devel] [PATCH v2 4/7] libcacard/vreader: Tighten assertion to clarify intent, Markus Armbruster, 2014/05/23
- Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups, Michael Tokarev, 2014/05/23
- Re: [Qemu-devel] [PATCH v2 0/7] libcacard: A few simple fixes and cleanups,
Michael Tokarev <=