[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: add usb_pick_speed
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH] usb: add usb_pick_speed |
Date: |
Tue, 27 May 2014 02:19:15 +0000 |
> -----Original Message-----
> From: address@hidden
> [mailto:address@hidden On
> Behalf Of Gerd Hoffmann
> Sent: Monday, May 26, 2014 4:58 PM
> To: address@hidden
> Cc: address@hidden; Gerd Hoffmann
> Subject: [Qemu-devel] [PATCH] usb: add usb_pick_speed
>
> We can pick the usb port speed in generic code, by looking at the port
> and device speed masks and looking for the fastest match. So add a
> function to do exactly that, and drop the speed setting code from
> usb_desc_attach as it isn't needed any more.
>
> This way we can set the device speed before calling port->ops->attach,
> which fixes some xhci hotplug issues.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1046873
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/usb/core.c | 21 +++++++++++++++++++++
> hw/usb/desc.c | 12 ------------
> include/hw/usb.h | 1 +
> 3 files changed, 22 insertions(+), 12 deletions(-)
>
Reviewed-by: Gonglei <address@hidden>
Best regards,
-Gonglei