[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() o
From: |
Christoffer Dall |
Subject: |
Re: [Qemu-devel] [PATCH v2] arm: Bugfix: Fix cpu_reset() / vcpu_init() order |
Date: |
Tue, 27 May 2014 14:39:03 +0200 |
On 27 May 2014 14:33, Andreas Färber <address@hidden> wrote:
> Am 27.05.2014 14:22, schrieb Christoffer Dall:
>> Commit 50a2c6e55fa introduced a bug where QEMU would segfault on startup
>> when using KVM on ARM hosts, because kvm_arm_reset_cpu() accesses
>> cpu->cpreg_reset_values, which is not allocated before
>> kvm_arch_init_vcpu(). Fix this by not calling cpu_reset() until after
>> qemu_init_vcpu().
>>
>> Acked-by: Paolo Bonzini <address@hidden>
>> Reviewed-by: Peter Maydell <address@hidden>
>> Signed-off-by: Christoffer Dall <address@hidden>
>> ---
>> Changes since v1:
>> - Updated commit message (current version by Peter Maydell)
>
> You missed updating the subject line. ;) That said,
>
> Reviewed-by: Andreas Färber <address@hidden>
>
goddammit, so much for my multi-tasking capabilities. Hopefully v3
gets the job done, if not, we're probably better off letting Peter fix
it:)
/me goes back to reviewing kvm patches