Re: [Qemu-devel] [PATCH 6/8] smbus: Fix unreachable code in smb_transaction()

[Paolo Bonzini]

Il 27/05/2014 03:40, address@hidden ha scritto:
> From: Gonglei <address@hidden>
>
> Spotted by Coverity:
>
> (1) Event unreachable:  This code cannot be reached: "abort();".
>
> 112         abort();
>
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/i2c/pm_smbus.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
> index fedb5fb..da09eb0 100644
> --- a/hw/i2c/pm_smbus.c
> +++ b/hw/i2c/pm_smbus.c
> @@ -109,7 +109,6 @@ static void smb_transaction(PMSMBus *s)
>      default:
>          goto error;
>      }
> -    abort();

This is intentional defensive programming.  A "break" from the switch 
would be wrong, hence the "abort" here.

Paolo

>  data16:
>      if (ret < 0) {