Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

[Paolo Bonzini]

Il 14/05/2014 17:42, Greg Kurz ha scritto:
> +    { .name = "virtio/is_big_endian",
> +      .version_id = 1,
> +      .save = virtio_save_device_endian,
> +      .load = virtio_load_device_endian,
> +    },
>      { .name = NULL }

I think this is okay, but you need to add support for a "needed" 
function like you have in normal vmstate subsections.  You only need the 
subsection if

    if (target_words_bigendian()) {
        return vdev->device_endian != VIRTIO_DEVICE_ENDIAN_BIG;
    } else {
        return vdev->device_endian != VIRTIO_DEVICE_ENDIAN_LITTLE;
    }

Paolo