Re: [Qemu-devel] [RFC PATCH 1/4] icount: Add 'align' and 'icount' options

[Paolo Bonzini]

Il 27/05/2014 16:54, Sebastian Tanase ha scritto:
> -                icount_option = optarg;
> +                opts = qemu_opts_parse(qemu_find_opts("icount"), optarg, 0);
> +                if (!opts) {
> +                    exit(1);
> +                }
> +                icount_option = qemu_opt_get(opts, "icount");
> +                if (icount_option) {
> +                    icount_align_option = qemu_opt_get_bool(opts, "align", 0);
> +                }

Please move this to configure_icount, making it take a QemuOpts * and 
Error **.  Then you can (for example) raise an error if one uses align 
and auto together.

Paolo