|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v3 11/34] memory: add memory_region_is_mapped() API |
Date: | Thu, 29 May 2014 17:28:34 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Il 29/05/2014 16:22, Peter Crosthwaite ha scritto:
> > +bool memory_region_is_mapped(MemoryRegion *mr) > +{Is it not enough to just return mr->parent? Memory mapping assertion will happen if you try and map the same twice, even if one of the mappings is not contained within an AddressSpace. Checking for just the parent mr may be a simpler and more accurate check.
I can see a difference if the memory region is completely overlapped by a higher-priority one. Igor, what was your idea with this function?
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |