[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface |
Date: |
Fri, 30 May 2014 09:44:20 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/30/2014 09:39 AM, Igor Mammedov wrote:
>>> +# @source_event: Arg0 - An Integer containing the source event
>>> +#
>>> +# @status_code: Arg1 – An Integer containing the status code
>>
>>> +{ 'type': 'ACPIOSTInfo',
>>> + 'data' : { 'device': 'str',
>>> + 'source': 'int',
>>> + 'status': 'int',
>>> + 'slot': 'int' } }
>>
>> ...this type declaration. I have no idea which one of the two is wrong.
> What do you mean under wrong?
Sorry for not being clear enough. I'm not sure whether you meant to
document four fields (device, source, status, and slot) or whether the
command should have been just two fields ( 'data': { 'source_event':
'int', 'status_code': 'int' } ).
Although re-reading what I just wrote, it appears your 'source' field
matches the 'source_event' documentation, the 'status' field matches the
'status_code' documentation, and you omitted the 'device' and 'slot'
documentation.
And my question in 4/5 remains - should 'source' and/or 'status' be
defined as an enum rather than an open-coded int?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [RFC 2/5] acpi: introduce TYPE_ACPI_DEVICE_IF interface, Igor Mammedov, 2014/05/28
[Qemu-devel] [RFC 3/5] acpi: implement ospm_status() method for PIIX4/ICH9_LPC devices, Igor Mammedov, 2014/05/28
[Qemu-devel] [RFC 4/5] qmp: add query-acpi-ospm-status command, Igor Mammedov, 2014/05/28
[Qemu-devel] [RFC 5/5] qmp: add ACPI_DEVICE_OST event handling, Igor Mammedov, 2014/05/28