[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC 1/5] nbd: Correct name comparison for export_set_name(
From: |
Max Reitz |
Subject: |
[Qemu-devel] [RFC 1/5] nbd: Correct name comparison for export_set_name() |
Date: |
Sat, 31 May 2014 20:43:08 +0200 |
exp->name == name is certainly true if both strings are equal and will
work for both of them being NULL (which is important to check here);
however, the strings may also be equal without having the same address,
in which case there is no need to replace the export's name either.
Therefore, add a check for this case.
Signed-off-by: Max Reitz <address@hidden>
---
nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/nbd.c b/nbd.c
index e5084b6..0787cba 100644
--- a/nbd.c
+++ b/nbd.c
@@ -832,7 +832,7 @@ NBDExport *nbd_export_find(const char *name)
void nbd_export_set_name(NBDExport *exp, const char *name)
{
- if (exp->name == name) {
+ if (exp->name == name || (exp->name && name && !strcmp(exp->name, name))) {
return;
}
--
1.9.3
- [Qemu-devel] [RFC 0/5] nbd: Adapt for dataplane, Max Reitz, 2014/05/31
- [Qemu-devel] [RFC 1/5] nbd: Correct name comparison for export_set_name(),
Max Reitz <=
- [Qemu-devel] [RFC 2/5] aio: Add io_read_poll() callback, Max Reitz, 2014/05/31
- [Qemu-devel] [RFC 3/5] nbd: Use aio_set_fd_handler2(), Max Reitz, 2014/05/31
- [Qemu-devel] [RFC 4/5] block: Add AIO followers, Max Reitz, 2014/05/31
- [Qemu-devel] [RFC 5/5] nbd: Follow the BDS' AIO context, Max Reitz, 2014/05/31
- Re: [Qemu-devel] [RFC 0/5] nbd: Adapt for dataplane, Max Reitz, 2014/05/31