[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 08/10] block: Drop superfluous aligning of bd
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v3 08/10] block: Drop superfluous aligning of bdrv_getlength()'s value |
Date: |
Mon, 2 Jun 2014 17:07:09 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Friday 30 May 2014 à 20:13:49 (+0200), Markus Armbruster wrote :
> It returns a multiple of the sector size.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
> block.c | 1 -
> block/qcow2.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 8ebfb79..41837b4 100644
> --- a/block.c
> +++ b/block.c
> @@ -1260,7 +1260,6 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs,
> int flags, Error **errp)
> error_setg_errno(errp, -total_size, "Could not get image size");
> goto out;
> }
> - total_size &= BDRV_SECTOR_MASK;
>
> /* Create the temporary image */
> ret = get_tmp_filename(tmp_filename, PATH_MAX + 1);
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 98f624c..4af09bd 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1927,7 +1927,6 @@ static int qcow2_write_compressed(BlockDriverState *bs,
> int64_t sector_num,
> /* align end of file to a sector boundary to ease reading with
> sector based I/Os */
> cluster_offset = bdrv_getlength(bs->file);
> - cluster_offset = (cluster_offset + 511) & ~511;
> bdrv_truncate(bs->file, cluster_offset);
> return 0;
> }
> --
> 1.9.3
>
>
Reviewed-by: Benoit Canet <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v3 08/10] block: Drop superfluous aligning of bdrv_getlength()'s value,
Benoît Canet <=