[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definiti
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json |
Date: |
Tue, 03 Jun 2014 09:01:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/31/2014 05:51 AM, BenoƮt Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> qapi-schema.json | 10 ----------
> qapi/block.json | 10 ++++++++++
> 2 files changed, 10 insertions(+), 10 deletions(-)
45-72: Reviewed-by: Eric Blake <address@hidden>
If you resend this series for any reason, PLEASE consolidate into fewer
patches. As long as the types are copied out of qapi-schema.json in the
same order that they are copied into block.json, it's much faster to
review that the code motion was done correctly if there is only one such
patch describing the motion to block.json than to read lots of tiny
patches one per struct/command.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json,
Eric Blake <=