[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fi
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out() |
Date: |
Thu, 12 Jun 2014 13:05:18 +0000 |
> -----Original Message-----
> From: Gerd Hoffmann [mailto:address@hidden
> Sent: Thursday, June 12, 2014 6:32 PM
> To: Peter Maydell
> Cc: Gonglei (Arei); QEMU Developers; Huangweidong (C); Luonengjun; Luiz
> Capitulino; Vassili Karpov; Stefan Hajnoczi; Paolo Bonzini
> Subject: Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in
> wav_fini_out()
>
> Hi,
>
> > > doclose:
> > > if (fclose (wav->f)) {
> > > - dolog ("wav_fini_out: fclose %p failed\nReason: %s\n",
> > > - wav->f, strerror (errno));
> > > + dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n",
> > > + strerror (errno));
> >
> > I would just drop the 'wav->f' here.
>
> Or drop the whole message? It's a highly unlikely error condition after
> all, and we can't do much about it anyway.
>
Agreed. Gerd, would you like a new version?
Best regards,
-Gonglei
[Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text, arei.gonglei, 2014/06/10
[Qemu-devel] [PATCH v3 2/4] qemu-bridge-helper: Fix fd leak in main(), arei.gonglei, 2014/06/10