[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional |
Date: |
Tue, 17 Jun 2014 16:25:27 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/17/2014 03:53 PM, Jeff Cody wrote:
> Now that active layer block-commit is supported, the 'top' argument
> no longer needs to be mandatory.
>
> Change it to optional, with the default being the active layer in the
> device chain.
>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Benoit Canet <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
As mentioned elsewhere, this is the patch that changed from v5. But so
there's no confusion, I've gone back over this one, and my R-b still stands.
> + /* Important Note:
> + * libvirt relies on the DeviceNotFound error class in order to probe
> for
> + * live commit feature versions; for this to work, we must make sure to
> + * perform the device lookup before any generic errors that may occur
> in a
> + * scenario in which all optional arguments are omitted. */
> bs = bdrv_find(device);
> if (!bs) {
> error_set(errp, QERR_DEVICE_NOT_FOUND, device);
Thanks for adding the comment :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v6 for 2.1 02/10] block: add helper function to determine if a BDS is in a chain, Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 03/10] block: simplify bdrv_find_base() and bdrv_find_overlay(), Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 04/10] block: make 'top' argument to block-commit optional, Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 05/10] block: Accept node-name arguments for block-commit, Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 06/10] block: extend block-commit to accept a string for the backing file, Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 07/10] block: add ability for block-stream to use node-name, Jeff Cody, 2014/06/17
[Qemu-devel] [PATCH v6 for 2.1 08/10] block: add backing-file option to block-stream, Jeff Cody, 2014/06/17