[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v4 PATCH] target-mips: implement UserLocal Register
From: |
Leon Alrae |
Subject: |
Re: [Qemu-devel] [v4 PATCH] target-mips: implement UserLocal Register |
Date: |
Wed, 18 Jun 2014 15:53:35 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Hi Petar,
>> @@ -4214,7 +4215,17 @@ static void gen_mfc0(DisasContext *ctx, TCGv arg, int
>> reg, int sel)
>> case 1:
>> // gen_helper_mfc0_contextconfig(arg); /* SmartMIPS ASE */
>> rn = "ContextConfig";
>> + goto die;
>> // break;
>> + case 2:
>> + if (ctx->ulri) {
>> + tcg_gen_ld32s_tl(arg, cpu_env,
>> + offsetof(CPUMIPSState,
>> + active_tc.CP0_UserLocal));
>> + rn = "UserLocal";
>> + } else {
>> + tcg_gen_movi_tl(arg, 0);
>> + }
>> default:
>> goto die;
>> }
You forgot to put "break" at the end of the case - this leads to
Reserved Instruction exception when trying to read the register.
Regards,
Leon