[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event
From: |
Paul Burton |
Subject: |
Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS |
Date: |
Sat, 21 Jun 2014 19:04:42 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Jun 21, 2014 at 02:02:55PM +0300, Riku Voipio wrote:
> On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote:
> > MIPS requires the pad field to 64b-align the data field just as ARM
> > does.
>
> Is this true for the 64bit mips also?
It appears so, good catch :)
Paul
> > Signed-off-by: Paul Burton <address@hidden>
> > ---
> > linux-user/syscall_defs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> > index 69c3982..9fcb723 100644
> > --- a/linux-user/syscall_defs.h
> > +++ b/linux-user/syscall_defs.h
> > @@ -2528,7 +2528,7 @@ typedef union target_epoll_data {
> >
> > struct target_epoll_event {
> > uint32_t events;
> > -#ifdef TARGET_ARM
> > +#if defined(TARGET_ARM) || defined(TARGET_MIPS)
> > uint32_t __pad;
> > #endif
> > target_epoll_data_t data;
> > --
> > 2.0.0
> >
signature.asc
Description: Digital signature
- Re: [Qemu-devel] [PATCH 01/16] linux-user: translate the result of getsockopt SO_TYPE, (continued)
- [Qemu-devel] [PATCH 02/16] linux-user: support SO_ACCEPTCONN getsockopt option, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 03/16] linux-user: support SO_{SND, RCV}BUFFORCE setsockopt options, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 04/16] linux-user: support SO_PASSSEC setsockopt option, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 05/16] linux-user: allow NULL arguments to mount, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 06/16] linux-user: support strace of epoll_create1, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 08/16] linux-user: respect timezone for settimeofday, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 09/16] linux-user: allow NULL tv argument for settimeofday, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 10/16] linux-user: support timerfd_{create, gettime, settime} syscalls, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 11/16] linux-user: support ioprio_{get, set} syscalls, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 12/16] linux-user: support {name_to, open_by}_handle_at syscalls, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 13/16] linux-user: support the setns syscall, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 15/16] linux-user: support the KDSIGACCEPT ioctl, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 14/16] linux-user: support the unshare syscall, Paul Burton, 2014/06/15
- [Qemu-devel] [PATCH 16/16] linux-user: support the SIOCGIFINDEX ioctl, Paul Burton, 2014/06/15