[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v1 16/24] monitor: Move more functions from monitor.
From: |
Benoît Canet |
Subject: |
[Qemu-devel] [PATCH v1 16/24] monitor: Move more functions from monitor.c to monitor-system.c |
Date: |
Fri, 1 Aug 2014 07:27:14 +0200 |
Signed-off-by: Benoit Canet <address@hidden>
---
monitor-system.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
monitor.c | 69 --------------------------------------------------------
2 files changed, 69 insertions(+), 69 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index 5b5f1ed..f8e4a10 100644
--- a/monitor-system.c
+++ b/monitor-system.c
@@ -2395,3 +2395,72 @@ int get_double(Monitor *mon, double *pval, const char
**pp)
size_t sizeof_mon_cmds = sizeof(mon_cmds);
size_t sizeof_info_cmds = sizeof(info_cmds);
+
+static void bdrv_password_cb(void *opaque, const char *password,
+ void *readline_opaque)
+{
+ Monitor *mon = opaque;
+ BlockDriverState *bs = readline_opaque;
+ int ret = 0;
+
+ if (bdrv_set_key(bs, password) != 0) {
+ monitor_printf(mon, "invalid password\n");
+ ret = -EPERM;
+ }
+ if (mon->password_completion_cb)
+ mon->password_completion_cb(mon->password_opaque, ret);
+
+ monitor_read_command(mon, 1);
+}
+
+ReadLineState *monitor_get_rs(Monitor *mon)
+{
+ return mon->rs;
+}
+
+int monitor_read_bdrv_key_start(Monitor *mon, BlockDriverState *bs,
+ BlockDriverCompletionFunc *completion_cb,
+ void *opaque)
+{
+ int err;
+
+ if (!bdrv_key_required(bs)) {
+ if (completion_cb)
+ completion_cb(opaque, 0);
+ return 0;
+ }
+
+ if (monitor_ctrl_mode(mon)) {
+ qerror_report(QERR_DEVICE_ENCRYPTED, bdrv_get_device_name(bs),
+ bdrv_get_encrypted_filename(bs));
+ return -1;
+ }
+
+ monitor_printf(mon, "%s (%s) is encrypted.\n", bdrv_get_device_name(bs),
+ bdrv_get_encrypted_filename(bs));
+
+ mon->password_completion_cb = completion_cb;
+ mon->password_opaque = opaque;
+
+ err = monitor_read_password(mon, bdrv_password_cb, bs);
+
+ if (err && completion_cb)
+ completion_cb(opaque, err);
+
+ return err;
+}
+
+int monitor_read_block_device_key(Monitor *mon, const char *device,
+ BlockDriverCompletionFunc *completion_cb,
+ void *opaque)
+{
+ BlockDriverState *bs;
+
+ bs = bdrv_find(device);
+ if (!bs) {
+ monitor_printf(mon, "Device not found %s\n", device);
+ return -1;
+ }
+
+ return monitor_read_bdrv_key_start(mon, bs, completion_cb, opaque);
+}
diff --git a/monitor.c b/monitor.c
index 419da13..79b54e1 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2978,75 +2978,6 @@ void monitor_init(CharDriverState *chr, int flags)
default_mon = mon;
}
-static void bdrv_password_cb(void *opaque, const char *password,
- void *readline_opaque)
-{
- Monitor *mon = opaque;
- BlockDriverState *bs = readline_opaque;
- int ret = 0;
-
- if (bdrv_set_key(bs, password) != 0) {
- monitor_printf(mon, "invalid password\n");
- ret = -EPERM;
- }
- if (mon->password_completion_cb)
- mon->password_completion_cb(mon->password_opaque, ret);
-
- monitor_read_command(mon, 1);
-}
-
-ReadLineState *monitor_get_rs(Monitor *mon)
-{
- return mon->rs;
-}
-
-int monitor_read_bdrv_key_start(Monitor *mon, BlockDriverState *bs,
- BlockDriverCompletionFunc *completion_cb,
- void *opaque)
-{
- int err;
-
- if (!bdrv_key_required(bs)) {
- if (completion_cb)
- completion_cb(opaque, 0);
- return 0;
- }
-
- if (monitor_ctrl_mode(mon)) {
- qerror_report(QERR_DEVICE_ENCRYPTED, bdrv_get_device_name(bs),
- bdrv_get_encrypted_filename(bs));
- return -1;
- }
-
- monitor_printf(mon, "%s (%s) is encrypted.\n", bdrv_get_device_name(bs),
- bdrv_get_encrypted_filename(bs));
-
- mon->password_completion_cb = completion_cb;
- mon->password_opaque = opaque;
-
- err = monitor_read_password(mon, bdrv_password_cb, bs);
-
- if (err && completion_cb)
- completion_cb(opaque, err);
-
- return err;
-}
-
-int monitor_read_block_device_key(Monitor *mon, const char *device,
- BlockDriverCompletionFunc *completion_cb,
- void *opaque)
-{
- BlockDriverState *bs;
-
- bs = bdrv_find(device);
- if (!bs) {
- monitor_printf(mon, "Device not found %s\n", device);
- return -1;
- }
-
- return monitor_read_bdrv_key_start(mon, bs, completion_cb, opaque);
-}
-
QemuOptsList qemu_mon_opts = {
.name = "mon",
.implied_opt_name = "chardev",
--
2.0.1
- [Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it, (continued)
- [Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 09/24] monitor: Make do_info_help public, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 06/24] monitor: Extract qmp_human_monitor_command into monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 13/24] monitor: Move do_loadvm from monitor.c to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 08/24] monitor: Extract a couple of function to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 05/24] monitor: Extract monitor_fprintf to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 22/24] qemu-nbd: build QAPI block core into qemu-nbd, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 16/24] monitor: Move more functions from monitor.c to monitor-system.c,
Benoît Canet <=
- [Qemu-devel] [PATCH v1 07/24] monitor: Make some function to extract public, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 12/24] monitor: Make do_loadvm public before moving it to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it., Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 24/24] qemu-nbd: Add --qmp option to qemu-nbd., Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 10/24] monitor: Extract do_info_help in monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 17/24] monitor: Move two net functions from monitor.c to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 18/24] monitor: Move qmp_rtc_reset_reinjection from monitor.c to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 19/24] monitor-system: Switch back functions to static, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 14/24] monitor: Make commands public before moving them to monitor-system.c, Benoît Canet, 2014/08/01