[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 12/30] ide: move BM_STATUS bits to pci.[ch]
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v2 12/30] ide: move BM_STATUS bits to pci.[ch] |
Date: |
Mon, 4 Aug 2014 17:11:13 -0400 |
From: Paolo Bonzini <address@hidden>
They are not used by AHCI, and should not be even available there.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/internal.h | 11 -----------
hw/ide/pci.c | 4 ++++
hw/ide/pci.h | 7 +++++++
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/hw/ide/internal.h b/hw/ide/internal.h
index b35e52c..f369b0b 100644
--- a/hw/ide/internal.h
+++ b/hw/ide/internal.h
@@ -484,10 +484,6 @@ struct IDEDevice {
uint64_t wwn;
};
-#define BM_STATUS_DMAING 0x01
-#define BM_STATUS_ERROR 0x02
-#define BM_STATUS_INT 0x04
-
/* FIXME These are not status register bits */
#define BM_STATUS_DMA_RETRY 0x08
#define BM_STATUS_PIO_RETRY 0x10
@@ -495,13 +491,6 @@ struct IDEDevice {
#define BM_STATUS_RETRY_FLUSH 0x40
#define BM_STATUS_RETRY_TRIM 0x80
-#define BM_MIGRATION_COMPAT_STATUS_BITS \
- (BM_STATUS_DMA_RETRY | BM_STATUS_PIO_RETRY | \
- BM_STATUS_RETRY_READ | BM_STATUS_RETRY_FLUSH)
-
-#define BM_CMD_START 0x01
-#define BM_CMD_READ 0x08
-
static inline IDEState *idebus_active_if(IDEBus *bus)
{
return bus->ifs + bus->unit;
diff --git a/hw/ide/pci.c b/hw/ide/pci.c
index 73267a4..0e82cab 100644
--- a/hw/ide/pci.c
+++ b/hw/ide/pci.c
@@ -33,6 +33,10 @@
#define BMDMA_PAGE_SIZE 4096
+#define BM_MIGRATION_COMPAT_STATUS_BITS \
+ (BM_STATUS_DMA_RETRY | BM_STATUS_PIO_RETRY | \
+ BM_STATUS_RETRY_READ | BM_STATUS_RETRY_FLUSH)
+
static void bmdma_start_dma(IDEDMA *dma, IDEState *s,
BlockDriverCompletionFunc *dma_cb)
{
diff --git a/hw/ide/pci.h b/hw/ide/pci.h
index 2428275..517711f 100644
--- a/hw/ide/pci.h
+++ b/hw/ide/pci.h
@@ -3,6 +3,13 @@
#include <hw/ide/internal.h>
+#define BM_STATUS_DMAING 0x01
+#define BM_STATUS_ERROR 0x02
+#define BM_STATUS_INT 0x04
+
+#define BM_CMD_START 0x01
+#define BM_CMD_READ 0x08
+
typedef struct BMDMAState {
IDEDMA dma;
uint8_t cmd;
--
1.9.3
- [Qemu-devel] [PATCH v2 02/30] libqtest: add QTEST_LOG for debugging qtest testcases, (continued)
- [Qemu-devel] [PATCH v2 02/30] libqtest: add QTEST_LOG for debugging qtest testcases, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 07/30] ide: simplify async_cmd_done callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 03/30] ide-test: add test for werror=stop, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 09/30] ide: wrap start_dma callback, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 08/30] ide: simplify start_transfer callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 06/30] ide: simplify set_inactive callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 11/30] ide: fold add_status callback into set_inactive, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 04/30] ide: stash aiocb for flushes, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 10/30] ide: remove wrong setting of BM_STATUS_INT, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 13/30] ide: move retry constants out of BM_STATUS_* namespace, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 12/30] ide: move BM_STATUS bits to pci.[ch],
John Snow <=
- [Qemu-devel] [PATCH v2 18/30] q35: Enable the ioapic device to be seen by qtest., John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 16/30] ide: make all commands go through cmd_done, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 15/30] ide: stop PIO transfer on errors, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 17/30] ahci: construct PIO Setup FIS for PIO commands, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 14/30] ahci: remove duplicate PORT_IRQ_* constants, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 21/30] libqtest: Correct small memory leak., John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 19/30] qtest: Adding qtest_memset and qmemset., John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 26/30] ahci: Add test_pci_spec to ahci-test., John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 30/30] ahci: Add test_identify case to ahci-test., John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 24/30] qtest/ide: Fix small memory leak, John Snow, 2014/08/04