[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: add some trace events
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] virtio-rng: add some trace events |
Date: |
Tue, 5 Aug 2014 12:45:46 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 04, 2014 at 04:22:44PM +0530, Amit Shah wrote:
> Add some trace events to virtio-rng for easier debugging
>
> Signed-off-by: Amit Shah <address@hidden>
>
> ---
> v2:
> - requested_size trace event now shows proper values
Reviewed-by: Amos Kong <address@hidden>
> ---
> hw/virtio/virtio-rng.c | 6 ++++++
> trace-events | 5 +++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index 03fd04a..e85a979 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -16,6 +16,7 @@
> #include "hw/virtio/virtio-rng.h"
> #include "sysemu/rng.h"
> #include "qom/object_interfaces.h"
> +#include "trace.h"
>
> static bool is_guest_ready(VirtIORNG *vrng)
> {
> @@ -24,6 +25,7 @@ static bool is_guest_ready(VirtIORNG *vrng)
> && (vdev->status & VIRTIO_CONFIG_S_DRIVER_OK)) {
> return true;
> }
> + trace_virtio_rng_guest_not_ready(vrng);
> return false;
> }
>
> @@ -62,6 +64,7 @@ static void chr_read(void *opaque, const void *buf, size_t
> size)
> offset += len;
>
> virtqueue_push(vrng->vq, &elem, len);
> + trace_virtio_rng_pushed(vrng, len);
> }
> virtio_notify(vdev, vrng->vq);
> }
> @@ -81,6 +84,9 @@ static void virtio_rng_process(VirtIORNG *vrng)
> quota = MIN((uint64_t)vrng->quota_remaining, (uint64_t)UINT32_MAX);
> }
> size = get_request_size(vrng->vq, quota);
> +
> + trace_virtio_rng_request(vrng, size, quota);
> +
> size = MIN(vrng->quota_remaining, size);
> if (size) {
> rng_backend_request_entropy(vrng->rng, size, chr_read, vrng);
> diff --git a/trace-events b/trace-events
> index 11a17a8..99f39ac 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -41,6 +41,11 @@ virtio_irq(void *vq) "vq %p"
> virtio_notify(void *vdev, void *vq) "vdev %p vq %p"
> virtio_set_status(void *vdev, uint8_t val) "vdev %p val %u"
>
> +# hw/virtio/virtio-rng.c
> +virtio_rng_guest_not_ready(void *rng) "rng %p: guest not ready"
> +virtio_rng_pushed(void *rng, size_t len) "rng %p: %zd bytes pushed"
> +virtio_rng_request(void *rng, size_t size, unsigned quota) "rng %p: %zd
> bytes requested, %u bytes quota left"
> +
> # hw/char/virtio-serial-bus.c
> virtio_serial_send_control_event(unsigned int port, uint16_t event, uint16_t
> value) "port %u, event %u, value %u"
> virtio_serial_throttle_port(unsigned int port, bool throttle) "port %u,
> throttle %d"
> --
> 1.9.3
--
Amos.