[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 5/7] hostmem-ram: don't exit qemu if size of memo
From: |
Hu Tao |
Subject: |
[Qemu-devel] [PATCH v6 5/7] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big |
Date: |
Thu, 7 Aug 2014 17:10:22 +0800 |
When using monitor command object_add to add a memory backend whose
size is way too big to allocate memory for it, qemu just exits. In
the case we'd better give an error message and keep guest running.
The problem can be reproduced as follows:
1. run qemu
2. (monitor)object_add memory-backend-ram,size=100000G,id=ram0
Reviewed-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Hu Tao <address@hidden>
---
backends/hostmem-ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c
index e55d066..a67a134 100644
--- a/backends/hostmem-ram.c
+++ b/backends/hostmem-ram.c
@@ -27,7 +27,7 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
path = object_get_canonical_path_component(OBJECT(backend));
memory_region_init_ram(&backend->mr, OBJECT(backend), path,
- backend->size, &error_abort);
+ backend->size, errp);
g_free(path);
}
--
1.9.3
- [Qemu-devel] [PATCH v6 0/7] memory API improvements and bug fixes for memory backends, Hu Tao, 2014/08/07
- [Qemu-devel] [PATCH v6 2/7] memory: add parameter errp to memory_region_init_ram, Hu Tao, 2014/08/07
- [Qemu-devel] [PATCH v6 3/7] memory: add parameter errp to memory_region_init_ram_ptr, Hu Tao, 2014/08/07
- [Qemu-devel] [PATCH v6 4/7] memory: add parameter errp to memory_region_init_rom_device, Hu Tao, 2014/08/07
- [Qemu-devel] [PATCH v6 5/7] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big,
Hu Tao <=
- [Qemu-devel] [PATCH v6 6/7] exec: report error when memory < hpagesize, Hu Tao, 2014/08/07
- [Qemu-devel] [PATCH v6 7/7] exec: add parameter errp to gethugepagesize, Hu Tao, 2014/08/07
Re: [Qemu-devel] [PATCH v6 0/7] memory API improvements and bug fixes for memory backends, Peter Crosthwaite, 2014/08/07