Re: [Qemu-devel] [PATCH v3 0/5] Allow VPC and VDI to be created over protocols

[Kevin Wolf]

Am 23.07.2014 um 23:22 hat Jeff Cody geschrieben:
> Changes from v2 -> v3:
>     * Patch 2: Removed extra #ifdef __linux__ from top of file (Max)
>     * Patch 4: Removed extra #ifdef __linux__ from top of file (Max)
>     * Patch 5: Removed output from debug cruft (Max)
>     * Added Max's R-b to remaining patches
> 
> Changes from v1 -> v2:
>     * Patch 2: Use'bs' instead of 'bs->file' (Max)
>     * Patch 3: Same as patch 2 (ripple through)
>     * Patch 5: Update VDI test for static image (Kevin)
>     * Added Max's R-b to patches 1,3,4
> 
> This allows VPC and VDI to be created over protocols; currently, they use
> posix calls directly to open, seek, and write into new image files.  This
> obviously precludes them from being able to be created over a protocol, like
> glusterfs.

Thanks, applied to the block branch.

I have one general remark, though: When creating an image, there's
little reason to use bdrv_pwrite_sync() instead of bdrv_pwrite(). If it
crashes in the middle, the file will be thrown away anyway. So it only
slows things down a bit for no benefit. Might be worth a follow-up.

Kevin