Re: [Qemu-devel] [PATCH v2 20/43] migrate_start_postcopy: Command to trigger transition to postcopy

[Eric Blake]

On 08/11/2014 08:29 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> Once postcopy is enabled (with migrate_set_capability), the migration
> will still start on precopy mode.  To cause a transition into postcopy
> the:
> 
>   migrate_start_postcopy
> 
> command must be issued.  Postcopy will start sometime after this
> (when it's next checked in the migration loop).
> 
> Issuing the command before migration has started will error,
> and issuing after it has finished is ignored.
> 
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
>  hmp-commands.hx               | 15 +++++++++++++++
>  hmp.c                         |  7 +++++++
>  hmp.h                         |  1 +
>  include/migration/migration.h |  3 +++
>  migration.c                   | 22 ++++++++++++++++++++++
>  qapi-schema.json              |  8 ++++++++
>  qmp-commands.hx               | 19 +++++++++++++++++++
>  7 files changed, 75 insertions(+)
> 

Reviewed-by: Eric Blake <address@hidden>

> +++ b/qapi-schema.json
> @@ -538,6 +538,14 @@
>  { 'command': 'query-migrate-capabilities', 'returns':   
> ['MigrationCapabilityStatus']}
>  
>  ##
> +# @migrate-start-postcopy
> +#
> +# Switch migration to postcopy mode
> +#
> +# Since: 2.2
> +{ 'command': 'migrate-start-postcopy' }
> +

Interface looks reasonable.  I haven't closely reviewed much else in the
series yet.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature