[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw
From: |
Tom Musta |
Subject: |
[Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw |
Date: |
Tue, 12 Aug 2014 08:45:06 -0500 |
For 64-bit implementations, the mullw result is the 64 bit product
of the sign-extended least significant 32 bits of the source
registers.
Fix the code to properly sign extend the source operands and produce
a 64 bit product.
Example:
R3 00000000002F37A0
R4 41C33D242F816715
mullw 3,3,4
R3 expected : 0008C3146AE0F020
R3 actual : 000000006AE0F020 (without this patch)
Signed-off-by: Tom Musta <address@hidden>
---
target-ppc/translate.c | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index f4cc495..41a5aea 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -1125,9 +1125,20 @@ static void gen_mulhwu(DisasContext *ctx)
/* mullw mullw. */
static void gen_mullw(DisasContext *ctx)
{
+#if defined(TARGET_PPC64)
+ TCGv_i64 t0, t1;
+ t0 = tcg_temp_new_i64();
+ t1 = tcg_temp_new_i64();
+ tcg_gen_ext32s_tl(t0, cpu_gpr[rA(ctx->opcode)]);
+ tcg_gen_ext32s_tl(t1, cpu_gpr[rB(ctx->opcode)]);
+ tcg_gen_mul_i64(cpu_gpr[rD(ctx->opcode)], t0, t1);
+ tcg_temp_free(t0);
+ tcg_temp_free(t1);
+#else
tcg_gen_mul_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)],
cpu_gpr[rB(ctx->opcode)]);
tcg_gen_ext32s_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)]);
+#endif
if (unlikely(Rc(ctx->opcode) != 0))
gen_set_Rc0(ctx, cpu_gpr[rD(ctx->opcode)]);
}
--
1.7.1
- [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 1/8] target-ppc: Bug Fix: rlwinm, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 2/8] target-ppc: Bug Fix: rlwnm, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 3/8] target-ppc: Bug Fix: rlwimi, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw,
Tom Musta <=
- [Qemu-devel] [V2 PATCH 5/8] target-ppc: Bug Fix: mullwo, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 6/8] target-ppc: Bug Fix: mulldo OV Detection, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 7/8] target-ppc: Bug Fix: srawi, Tom Musta, 2014/08/12
- [Qemu-devel] [V2 PATCH 8/8] target-ppc: Bug Fix: srad, Tom Musta, 2014/08/12
- Re: [Qemu-devel] [V2 PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions, Alexander Graf, 2014/08/12