[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tabl
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables |
Date: |
Thu, 14 Aug 2014 13:51:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2014-08-14 13:43, Michael S. Tsirkin wrote:
> On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote:
>> On 2014-08-14 13:06, Michael S. Tsirkin wrote:
>>> On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote:
>>>> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE
>>>> exists,
>>>> add DMAR table to ACPI RSDT table. For now the DMAR table indicates that
>>>> there
>>>> is only one hardware unit without INTR_REMAP capability on the platform.
>>>>
>>>> Signed-off-by: Le Tan <address@hidden>
>>>
>>> Could you add a unit test please?
>>
>> While unit tests would really be helpful, I'm afraid that's not in reach
>> (GSoC is almost over). The good news is that we have pretty broad test
>> coverage with both Linux and also Jailhouse already.
>>
>> Do you see unit tests as precondition for merging the series?
>>
>> Jan
>>
>
> Not a pre-requisite - it's very easy to add a unit test,
> just add a case in test_acpi_tcg. So I can do it myself afterwards.
>
Ah, ok, that's tests/bios-tables-test.c. Maybe Le can have a look if
time is left. But hard pecils-down is already on the 18th.
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 1/5] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, (continued)
- [Qemu-devel] [PATCH v3 1/5] iommu: add is_write as a parameter to the translate function of MemoryRegionIOMMUOps, Le Tan, 2014/08/11
- [Qemu-devel] [PATCH v3 4/5] intel-iommu: add Intel IOMMU emulation to q35 and add a machine option "iommu" as a switch, Le Tan, 2014/08/11
- [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Le Tan, 2014/08/11
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Jan Kiszka, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Le Tan, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables, Le Tan, 2014/08/14
- [Qemu-devel] [PATCH v3 5/5] intel-iommu: add supports for queued invalidation interface, Le Tan, 2014/08/11
- Re: [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset, Michael S. Tsirkin, 2014/08/14