[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD register
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD register |
Date: |
Thu, 14 Aug 2014 18:09:52 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 14, 2014 at 12:13:51PM -0400, John Snow wrote:
>
>
> On 08/14/2014 12:09 PM, Stefan Hajnoczi wrote:
> >On Wed, Aug 13, 2014 at 05:56:12PM -0400, John Snow wrote:
> >>@@ -497,6 +495,8 @@ static void ahci_reset_port(AHCIState *s, int port)
> >> pr->scr_stat = 0;
> >> pr->scr_err = 0;
> >> pr->scr_act = 0;
> >>+ pr->tfdata = 0x7F;
> >
> >Is it possible to avoid the magic number?
> >
>
> I can name it as AHCI_TFD_BOOT_VALUE or AHCI_TFD_INIT_VALUE or so. Same for
> the PxSIG boot value too. I don't think I can give any greater meaning to
> the value because it's just a boot signature that means "We haven't received
> an FIS yet."
In that case, don't bother. I thought this was error and status fields
shifted.
Stefan
pgpjPyHCTL2V9.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v3 30/32] ahci: Add test_hba_spec to ahci-test., (continued)