[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/12] numa: show hex number in error message for
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x |
|
Date: |
Thu, 14 Aug 2014 21:22:14 +0200 |
On Thu, Aug 14, 2014 at 03:57:53PM -0300, Eduardo Habkost wrote:
> On Thu, Aug 14, 2014 at 06:09:03PM +0200, Michael S. Tsirkin wrote:
> > From: Hu Tao <address@hidden>
> >
> > The error messages before and after patch are:
> >
> > before:
> > qemu-system-x86_64: total memory for NUMA nodes (134217728) should equal
> > RAM size (20000000)
> >
> > after:
> > qemu-system-x86_64: total memory for NUMA nodes (0x8000000) should equal
> > RAM size (0x20000000)
>
> Why hex? Why not change both to decimal?
Reasonable number is usually very large and a power of 2,
hex is easier to read.
> --
> Eduardo
- [Qemu-devel] [PULL 00/12] post-2.1 bugfixes, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 02/12] pc: Create 2.2 machine type, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 01/12] pci: Use bus master address space for delivering MSI/MSI-X messages, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 04/12] hw:i386: typo fix: MEMORY_HOPTLUG_DEVICE -> MEMORY_HOTPLUG_DEVICE, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 05/12] pc-dimm: validate node property, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 06/12] pc-dimm: fix up error message, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 07/12] numa: show hex number in error message for consistency and prefix them with 0x, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 08/12] acpi: align RSDP, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 09/12] ivshmem: fix building when debug mode is enabled, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 03/12] hw/audio/intel-hda: Fix MSI capability address, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 10/12] e1000: correctly handle phy_ctrl reserved & self-clearing bits, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 11/12] e1000: use symbolic constants to init phy ctrl & status registers, Michael S. Tsirkin, 2014/08/14
- [Qemu-devel] [PULL 12/12] pc: Get rid of pci-info leftovers, Michael S. Tsirkin, 2014/08/14
- Re: [Qemu-devel] [PULL 00/12] post-2.1 bugfixes, Peter Maydell, 2014/08/15