[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 13/20] vmxnet3: don't use 'Yoda conditions'
From: |
Michael Tokarev |
Subject: |
[Qemu-devel] [PULL 13/20] vmxnet3: don't use 'Yoda conditions' |
Date: |
Fri, 15 Aug 2014 19:15:04 +0400 |
From: Gonglei <address@hidden>
imitate nearby code about using '!value' or 'value == NULL'
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/net/vmxnet3.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 77bea6f..588149d 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1009,7 +1009,7 @@ vmxnet3_indicate_packet(VMXNET3State *s)
vmxnet3_dump_rx_descr(&rxd);
- if (0 != ready_rxcd_pa) {
+ if (ready_rxcd_pa != 0) {
cpu_physical_memory_write(ready_rxcd_pa, &rxcd, sizeof(rxcd));
}
@@ -1020,7 +1020,7 @@ vmxnet3_indicate_packet(VMXNET3State *s)
rxcd.gen = new_rxcd_gen;
rxcd.rqID = RXQ_IDX + rx_ridx * s->rxq_num;
- if (0 == bytes_left) {
+ if (bytes_left == 0) {
vmxnet3_rx_update_descr(s->rx_pkt, &rxcd);
}
@@ -1038,16 +1038,16 @@ vmxnet3_indicate_packet(VMXNET3State *s)
num_frags++;
}
- if (0 != ready_rxcd_pa) {
+ if (ready_rxcd_pa != 0) {
rxcd.eop = 1;
- rxcd.err = (0 != bytes_left);
+ rxcd.err = (bytes_left != 0);
cpu_physical_memory_write(ready_rxcd_pa, &rxcd, sizeof(rxcd));
/* Flush RX descriptor changes */
smp_wmb();
}
- if (0 != new_rxcd_pa) {
+ if (new_rxcd_pa != 0) {
vmxnet3_revert_rxc_descr(s, RXQ_IDX);
}
@@ -1190,8 +1190,8 @@ static void vmxnet3_update_mcast_filters(VMXNET3State *s)
s->mcast_list_len = list_bytes / sizeof(s->mcast_list[0]);
s->mcast_list = g_realloc(s->mcast_list, list_bytes);
- if (NULL == s->mcast_list) {
- if (0 == s->mcast_list_len) {
+ if (!s->mcast_list) {
+ if (s->mcast_list_len == 0) {
VMW_CFPRN("Current multicast list is empty");
} else {
VMW_ERPRN("Failed to allocate multicast list of %d elements",
@@ -1667,7 +1667,7 @@ vmxnet3_io_bar1_write(void *opaque,
* memory address. We save it to temp variable and set the
* shared address only after we get the high part
*/
- if (0 == val) {
+ if (val == 0) {
s->device_active = false;
}
s->temp_shared_guest_driver_memory = val;
--
1.7.10.4
- [Qemu-devel] [PULL 00/20] Trivial patches for 2014-08-15, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 02/20] memory: Update obsolete comment about AddrRange field type, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 08/20] audio: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 01/20] apic: Fix reported DFR content, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 07/20] usb: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 06/20] CODING_STYLE: Section about conditional statement, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 13/20] vmxnet3: don't use 'Yoda conditions',
Michael Tokarev <=
- [Qemu-devel] [PULL 19/20] l2cap: fix access to freed memory, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 14/20] qemu-options.hx: fix typo about l2tpv3, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 16/20] ssi: xilinx_spi: Initialise CS GPIOs as NULL, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 20/20] ivshmem: check the value returned by fstat(), Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 12/20] vl: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 11/20] spice: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 04/20] pci-host: update obsolete reference about piix_pci.c, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 09/20] isa-bus: don't use 'Yoda conditions', Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 03/20] qemu-options.hx: fix a typo of chardev, Michael Tokarev, 2014/08/15
- [Qemu-devel] [PULL 05/20] pci-host: update uncorresponding description, Michael Tokarev, 2014/08/15