Re: [Qemu-devel] [PATCH v7] tests/bios-tables-test: check the value returned by fopen()

[Peter Maydell]

On 18 August 2014 08:54, zhanghailiang <address@hidden> wrote:
> The function fopen() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Li Liu <address@hidden>
> Reviewed-by: Alex Bennée <address@hidden>
> ---
>  tests/bios-tables-test.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 045eb27..feb3b58 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -790,6 +790,11 @@ int main(int argc, char *argv[])
>      const char *arch = qtest_get_arch();
>      FILE *f = fopen(disk, "w");
>      int ret;
> +
> +    if (!f) {
> +        fprintf(stderr, "Couldn't open \"%s\": %s", disk, strerror(errno));
> +        return -1;
> +    }

-1 isn't a sensible value to return from main(); you want 1.
(Program exit statuses can only be 0 or positive.)

thanks
-- PMM