[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 2/4] arm_gic: GICD_ICFGR: Write model only for pr
From: |
Adam Lackorzynski |
Subject: |
[Qemu-devel] [PATCH v4 2/4] arm_gic: GICD_ICFGR: Write model only for pre v1 GICs |
Date: |
Mon, 18 Aug 2014 16:30:53 +0200 |
Setting the model is only available in pre-v1 GIC models.
Acked-by: Christoffer Dall <address@hidden>
Signed-off-by: Adam Lackorzynski <address@hidden>
---
hw/intc/arm_gic.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/intc/arm_gic.c b/hw/intc/arm_gic.c
index d2b1aaf..e546647 100644
--- a/hw/intc/arm_gic.c
+++ b/hw/intc/arm_gic.c
@@ -561,10 +561,12 @@ static void gic_dist_writeb(void *opaque, hwaddr offset,
if (irq < GIC_INTERNAL)
value |= 0xaa;
for (i = 0; i < 4; i++) {
- if (value & (1 << (i * 2))) {
- GIC_SET_MODEL(irq + i);
- } else {
- GIC_CLEAR_MODEL(irq + i);
+ if (s->revision == REV_11MPCORE || s->revision == REV_NVIC) {
+ if (value & (1 << (i * 2))) {
+ GIC_SET_MODEL(irq + i);
+ } else {
+ GIC_CLEAR_MODEL(irq + i);
+ }
}
if (value & (2 << (i * 2))) {
GIC_SET_EDGE_TRIGGER(irq + i);
--
2.1.0.rc1
- [Qemu-devel] [PATCH v4 0/4] Improve handling of GICD_ICFGR, Adam Lackorzynski, 2014/08/18
- [Qemu-devel] [PATCH v4 2/4] arm_gic: GICD_ICFGR: Write model only for pre v1 GICs,
Adam Lackorzynski <=
- [Qemu-devel] [PATCH v4 3/4] arm_gic: Do not force PPIs to edge-triggered mode, Adam Lackorzynski, 2014/08/18
- [Qemu-devel] [PATCH v4 4/4] arm_gic: Use GIC_NR_SGIS constant, Adam Lackorzynski, 2014/08/18
- [Qemu-devel] [PATCH v4 1/4] arm_gic: Fix read of GICD_ICFGR, Adam Lackorzynski, 2014/08/18
- Re: [Qemu-devel] [PATCH v4 0/4] Improve handling of GICD_ICFGR, Adam Lackorzynski, 2014/08/21
- Re: [Qemu-devel] [PATCH v4 0/4] Improve handling of GICD_ICFGR, Peter Maydell, 2014/08/29