[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] qemu-io-cmds: g_renew() can't fail, bury
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] qemu-io-cmds: g_renew() can't fail, bury dead error handling |
Date: |
Mon, 18 Aug 2014 15:59:02 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Aug 18, 2014 at 06:10:42PM +0200, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-io-cmds.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
> index afd8867..b224ede 100644
> --- a/qemu-io-cmds.c
> +++ b/qemu-io-cmds.c
> @@ -115,22 +115,13 @@ static char **breakline(char *input, int *count)
> int c = 0;
> char *p;
> char **rval = g_new0(char *, 1);
> - char **tmp;
>
> while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
> if (!*p) {
> continue;
> }
> c++;
> - tmp = g_renew(char *, rval, (c + 1));
> - if (!tmp) {
> - g_free(rval);
> - rval = NULL;
> - c = 0;
> - break;
> - } else {
> - rval = tmp;
> - }
> + rval = g_renew(char *, rval, (c + 1));
> rval[c - 1] = p;
> rval[c] = NULL;
> }
> --
> 1.9.3
>
>
Reviewed-by: Jeff Cody <address@hidden>
- Re: [Qemu-devel] [PATCH v2 4/4] block: Drop some superfluous casts from void *, (continued)
[Qemu-devel] [PATCH v2 1/4] block: Use g_new() & friends where that makes obvious sense, Markus Armbruster, 2014/08/18
[Qemu-devel] [PATCH v2 3/4] qemu-io-cmds: g_renew() can't fail, bury dead error handling, Markus Armbruster, 2014/08/18