Re: [Qemu-devel] [PATCH] pcihp: fix possible array out of bounds

[Peter Crosthwaite]

On Tue, Aug 19, 2014 at 5:18 PM,  <address@hidden> wrote:
> From: Gonglei <address@hidden>
>
> When 'bsel == ACPI_PCIHP_MAX_HOTPLUG_BUS', the
> s->acpi_pcihp_pci_status[bsel] array will out of bounds.
>
> Add check for this.
>
> Signed-off-by: Gonglei <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  hw/acpi/pcihp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
> index fae663a..34dedf1 100644
> --- a/hw/acpi/pcihp.c
> +++ b/hw/acpi/pcihp.c
> @@ -231,7 +231,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, 
> unsigned int size)
>      uint32_t val = 0;
>      int bsel = s->hotplug_select;
>
> -    if (bsel < 0 || bsel > ACPI_PCIHP_MAX_HOTPLUG_BUS) {
> +    if (bsel < 0 || bsel >= ACPI_PCIHP_MAX_HOTPLUG_BUS) {
>          return 0;
>      }
>
> --
> 1.7.12.4
>
>
>