Re: [Qemu-devel] [RFC 0/4] Adding -cdrom, -hd[abcd] and -drive file=... to Q35

[Dr. David Alan Gilbert]

* John Snow (address@hidden) wrote:

<snip>

> The changes appear to work well, but where I'd like some feedback
> is what should happen if people do something like:
> 
> qemu -M q35 -drive if=ide,file=fedora.qcow2
> 
> The code as presented here is not going to look for or attempt to
> connect IDE devices, because it is now looking for /AHCI/ devices.

What happens if you try it - does it just silently ignore that -drive?
The ideal would be for something to moan about unused drives so people
realise why it's broken; but I seem to remember form a previous discussion
it's hard to do on all platforms.

Dave

> 
> At worst, this may break a few existing scripts, but I actually think
> that since the if=ide,file=... shorthand never worked to begin with,
> the impact might actually be minimal.
> 
> But since the legacy IDE interface of the ICH9 is as of yet unemulated,
> the if=ide drives don't have a reasonable place to go yet. I am also
> not sure what a reasonable way to handle people specifying BOTH
> if=ide and if=ahci drives would be.
> 
> John Snow (4):
>   blockdev: add if_get_max_devs
>   blockdev: add IF_AHCI to support -cdrom and -hd[a-d]
>   ide: update ide_drive_get to work with both PCI-IDE and AHCI
>     interfaces
>   ahci: implement -cdrom and -hd[a-d]
> 
>  blockdev.c                | 18 +++++++++++++++---
>  hw/i386/pc_piix.c         |  2 +-
>  hw/i386/pc_q35.c          |  4 ++++
>  hw/ide/ahci.c             | 17 +++++++++++++++++
>  hw/ide/ahci.h             |  2 ++
>  hw/ide/core.c             | 11 +++++++----
>  include/hw/ide.h          |  3 ++-
>  include/sysemu/blockdev.h |  3 ++-
>  8 files changed, 50 insertions(+), 10 deletions(-)
> 
> -- 
> 1.9.3
> 
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK