[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as th
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name |
Date: |
Wed, 20 Aug 2014 15:01:12 +1000 |
On Wed, Aug 20, 2014 at 4:51 AM, Peter Maydell <address@hidden> wrote:
> On 19 August 2014 11:43, Paolo Bonzini <address@hidden> wrote:
>> From: Peter Crosthwaite <address@hidden>
>>
>> Rather than having the name as separate state. This prepares support
>> for creating a MemoryRegion dynamically (i.e. without
>> memory_region_init() and friends) and the MemoryRegion still getting
>> a usable name.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> This commit seems to have broken builds with Xen:
>
> CC i386-softmmu/xen-hvm.o
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c: In function
> ‘xen_add_to_physmap’:
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:333:31: error:
> ‘MemoryRegion’ has no member named ‘name’
> physmap->name = (char *)mr->name;
> ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:357:11: error:
> ‘MemoryRegion’ has no member named ‘name’
> if (mr->name) {
> ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:361:51: error:
> ‘MemoryRegion’ has no member named ‘name’
> if (!xs_write(state->xenstore, 0, path, mr->name, strlen(mr->name)))
> {
> ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:361:68: error:
> ‘MemoryRegion’ has no member named ‘name’
> if (!xs_write(state->xenstore, 0, path, mr->name, strlen(mr->name)))
> {
> ^
> make[1]: *** [xen-hvm.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
>
> I should have spotted this as part of my pre-merge
> tests, but somehow it slipped through -- sorry.
>
You and me both. Added Xen to my pre-send compile testing.
The fix for this is reasonably trivial and just follows the change
pattern for the other usages as fixed in original series. Patch on
list imminently.
Regards,
Peter
> -- PMM
>
- [Qemu-devel] [PULL 11/20] ioport: split deletion and destruction, (continued)
- [Qemu-devel] [PULL 11/20] ioport: split deletion and destruction, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 12/20] memory: convert memory_region_destroy to object_unparent, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 13/20] memory: remove memory_region_destroy, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 14/20] tpm_tis: remove instance_finalize callback, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 15/20] loader: Abstract away ref to memory region names, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 16/20] exec: Abstract away ref to memory region names, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 17/20] memory: constify memory_region_name, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 18/20] memory: Use memory_region_name for name access, Paolo Bonzini, 2014/08/19
- [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name, Paolo Bonzini, 2014/08/19
[Qemu-devel] [PULL 20/20] mtree: remove write-only field, Paolo Bonzini, 2014/08/19
Re: [Qemu-devel] [PULL 00/20] SCSI and memory changes for 2014-08-18, Peter Maydell, 2014/08/19