[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 9/9] scsi: Cancel request asynchronously
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [RFC PATCH 9/9] scsi: Cancel request asynchronously |
Date: |
Fri, 22 Aug 2014 12:57:15 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 08/21 14:19, Paolo Bonzini wrote:
> Il 21/08/2014 13:56, Fam Zheng ha scritto:
> > We are blocking the whole VM, which means that an irresponsive storage
> > backend will hang the whole guest. Let's switch to bdrv_aio_cancel_async
> > to improve this.
>
> Unforuntately, the TMF must only return after the request has been
> canceled. I think you need to add a scsi_cancel_io_async function, and
> keep all the remaining machinery (also, you need a better commit message
> that explains what you are removing and the new invariants).
>
> Then in virtio-scsi you need to add a list of "dependent" (controlq)
> VirtIOSCSIReq to the "main" (requestq) VirtIOSCSIReq, and complete them
> all after signaling the completion of the main request.
OK, I didn't know that. I'll try again :)
Thanks,
Fam
- [Qemu-devel] [RFC PATCH 5/9] thread-pool: Implement .cancel_async, (continued)
- [Qemu-devel] [RFC PATCH 5/9] thread-pool: Implement .cancel_async, Fam Zheng, 2014/08/21
- [Qemu-devel] [RFC PATCH 7/9] dma: Implement .cancel_async, Fam Zheng, 2014/08/21
- [Qemu-devel] [RFC PATCH 8/9] block: Implement stub bdrv_em_co_aiocb_info.cancel_async, Fam Zheng, 2014/08/21
- [Qemu-devel] [RFC PATCH 6/9] blkdebug: Implement .cancel_async, Fam Zheng, 2014/08/21
- [Qemu-devel] [RFC PATCH 9/9] scsi: Cancel request asynchronously, Fam Zheng, 2014/08/21