[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH memory v2 1/3] xen-hvm: Constify string
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH memory v2 1/3] xen-hvm: Constify string |
Date: |
Tue, 26 Aug 2014 07:37:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Am 26.08.2014 um 05:09 schrieb Peter Crosthwaite:
> It's constant, and sourced from existing const strings. Avoid dodgy
> casts by converting to const.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> xen-hvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen-hvm.c b/xen-hvm.c
> index 91de2e2..d763e86 100644
> --- a/xen-hvm.c
> +++ b/xen-hvm.c
> @@ -71,7 +71,7 @@ static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t
> *shared_page, int vcpu)
> typedef struct XenPhysmap {
> hwaddr start_addr;
> ram_addr_t size;
> - char *name;
> + const char *name;
> hwaddr phys_offset;
>
> QLIST_ENTRY(XenPhysmap) list;
> @@ -330,7 +330,7 @@ go_physmap:
>
> physmap->start_addr = start_addr;
> physmap->size = size;
> - physmap->name = (char *)mr->name;
> + physmap->name = mr->name;
> physmap->phys_offset = phys_offset;
>
> QLIST_INSERT_HEAD(&state->physmap, physmap, list);
>
Thanks.
Reviewed-by: Stefan Weil <address@hidden>