[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vl: process -object after other backend options
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] vl: process -object after other backend options |
Date: |
Wed, 27 Aug 2014 14:34:00 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 25, 2014 at 02:17:04PM +0200, Paolo Bonzini wrote:
> QOM backends can refer to chardevs, but not vice versa. So
> process -chardev and -fsdev options before -object
>
> This fixes the rng-egd backend to virtio-rng.
>
> Reported-by: Amos Kong <address@hidden>
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> vl.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Option ordering is a bad idea. With an option as generic as -object,
who can say that there will never be a non-object that depends on an
-object?
We should process the command-line left-to-right instead of ordering by
option type. Maybe that would be a good QEMU 3.0 feature! :)
Feel free to merge if it works for now, but we'll need a better fix in
the future.
Stefan
pgpczFgtUAHq7.pgp
Description: PGP signature