[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization |
Date: |
Wed, 27 Aug 2014 14:51:10 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Aug 25, 2014 at 10:36:08AM +0200, Marc Marí wrote:
> +static uint16_t qvirtio_pci_config_readw(QVirtioDevice *d, void *addr)
> +{
> + QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> + return qpci_io_readw(dev->pdev, addr);
> +}
> +
> +static uint32_t qvirtio_pci_config_readl(QVirtioDevice *d, void *addr)
> +{
> + QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> + return qpci_io_readl(dev->pdev, addr);
> +}
> +
> +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void *addr)
> +{
> + QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d;
> + int i;
> + union {
> + uint8_t bytes[8];
> + uint64_t u64;
> + } quad;
> +
> + for (i = 0; i < 8; ++i) {
> + quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i);
> + }
> +
> + return quad.u64;
> +}
readw and readl are in host CPU endianness.
readq is in guest CPU endianness.
Please use qtest readq so that endianness is consistent.
pgpcopMWUhAs4.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v6 0/7] Virtio PCI libqos driver, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 1/7] tests: Functions bus_foreach and device_find from libqos virtio API, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization, Marc Marí, 2014/08/25
- Re: [Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v6 3/7] libqos: Added basic virtqueue support to virtio implementation, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 4/7] libqos: Added indirect descriptor support to virtio implementation, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 5/7] libqos: Added test case for configuration changes in virtio-blk test, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 6/7] libqos: Added MSI-X support, Marc Marí, 2014/08/25
- [Qemu-devel] [PATCH v6 7/7] libqos: Added EVENT_IDX support, Marc Marí, 2014/08/25
- Re: [Qemu-devel] [PATCH v6 0/7] Virtio PCI libqos driver, Stefan Hajnoczi, 2014/08/27