[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings |
Date: |
Wed, 27 Aug 2014 16:17:42 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Wednesday 27 Aug 2014 à 12:08:54 (+0100), Stefan Hajnoczi wrote :
> The gcc 4.1.2 compiler warns that delay_ns may be uninitialized in
> mirror_iteration().
>
> There are two break statements in the do ... while loop that skip over
> the delay_ns assignment. These are probably the cause of the warning.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> block/mirror.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index 5e7a166..18b18e0 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -157,7 +157,7 @@ static uint64_t coroutine_fn
> mirror_iteration(MirrorBlockJob *s)
> BlockDriverState *source = s->common.bs;
> int nb_sectors, sectors_per_chunk, nb_chunks;
> int64_t end, sector_num, next_chunk, next_sector, hbitmap_next_sector;
> - uint64_t delay_ns;
> + uint64_t delay_ns = 0;
> MirrorOp *op;
>
> s->sector_num = hbitmap_iter_next(&s->hbi);
> @@ -247,8 +247,6 @@ static uint64_t coroutine_fn
> mirror_iteration(MirrorBlockJob *s)
> next_chunk += added_chunks;
> if (!s->synced && s->common.speed) {
> delay_ns = ratelimit_calculate_delay(&s->limit, added_sectors);
> - } else {
> - delay_ns = 0;
> }
> } while (delay_ns == 0 && next_sector < end);
>
> --
> 1.9.3
>
>
Reviewed-by: Benoît Canet <address@hidden>
- [Qemu-devel] [PATCH v2 0/6] Fixes for buildbot failures, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 1/6] qapi.py: avoid Python 2.5+ any() function, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 2/6] libqtest: launch QEMU with QEMU_AUDIO_DRV=none, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 3/6] trace: avoid Python 2.5 all() in tracetool, Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings, Stefan Hajnoczi, 2014/08/27
- Re: [Qemu-devel] [PATCH v2 4/6] mirror: fix uninitialized variable delay_ns warnings,
Benoît Canet <=
- [Qemu-devel] [PATCH v2 5/6] block: sort formats alphabetically in bdrv_iterate_format(), Stefan Hajnoczi, 2014/08/27
- [Qemu-devel] [PATCH v2 6/6] Revert "qemu-img: sort block formats in help message", Stefan Hajnoczi, 2014/08/27