[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/3] nfs: Fix leak of opts in nfs_file_open
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/3] nfs: Fix leak of opts in nfs_file_open |
Date: |
Thu, 28 Aug 2014 08:43:17 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Thursday 28 Aug 2014 à 13:56:10 (+0800), Fam Zheng wrote :
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/nfs.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/block/nfs.c b/block/nfs.c
> index 93d87f3..194f301 100644
> --- a/block/nfs.c
> +++ b/block/nfs.c
> @@ -393,16 +393,20 @@ static int nfs_file_open(BlockDriverState *bs, QDict
> *options, int flags,
> qemu_opts_absorb_qdict(opts, options, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> - return -EINVAL;
> + ret = -EINVAL;
> + goto out;
> }
> ret = nfs_client_open(client, qemu_opt_get(opts, "filename"),
> (flags & BDRV_O_RDWR) ? O_RDWR : O_RDONLY,
> errp);
> if (ret < 0) {
> - return ret;
> + goto out;
> }
> bs->total_sectors = ret;
> - return 0;
> + ret = 0;
> +out:
> + qemu_opts_del(opts);
> + return ret;
> }
>
> static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp)
> --
> 2.1.0
>
>
Reviewed-by: Benoît Canet <address@hidden>