[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 03/17] Fix OHCI ISO TD state never being written back
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 03/17] Fix OHCI ISO TD state never being written back. |
Date: |
Fri, 29 Aug 2014 14:03:38 +0200 |
From: Jack Un <address@hidden>
There appears to be typo in OHCI with isochronous transfers
resulting in isoch. transfer descriptor state never being written back.
The'put_words' function is in a OR statement hence it is never called.
Signed-off-by: Jack Un <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
hw/usb/hcd-ohci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index 13afdf5..cacf7b0 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -619,8 +619,8 @@ static inline int ohci_put_td(OHCIState *ohci,
static inline int ohci_put_iso_td(OHCIState *ohci,
dma_addr_t addr, struct ohci_iso_td *td)
{
- return put_dwords(ohci, addr, (uint32_t *)td, 4 ||
- put_words(ohci, addr + 16, td->offset, 8));
+ return put_dwords(ohci, addr, (uint32_t *)td, 4) ||
+ put_words(ohci, addr + 16, td->offset, 8);
}
static inline int ohci_put_hcca(OHCIState *ohci,
--
1.8.3.1
- [Qemu-devel] [PULL 01/17] usb: Fix bootindex for portnr > 9, (continued)
- [Qemu-devel] [PULL 01/17] usb: Fix bootindex for portnr > 9, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 05/17] Revert "xhci: Fix number of streams allocated when using streams", Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 08/17] usb-ohci: add exit function, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 02/17] xhci: fix debug print compiling error, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 11/17] usb-ehci: add ehci unrealize funciton, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 10/17] usb-ehci: add vmstate properity for EHCIState, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 12/17] usb-ehci: add ehci-pci device exit function, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 06/17] usb: add usb_bus_release function, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 13/17] usb-xhci: add exit function, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 15/17] tests: add OHCI qtest, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 03/17] Fix OHCI ISO TD state never being written back.,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 14/17] usb: add usb host adapters exit trace, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 07/17] usb-ohci: Fix memory leak for ohci timer, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 17/17] tests: add xHCI qtest, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 16/17] tests: add UHCI qtest, Gerd Hoffmann, 2014/08/29
- [Qemu-devel] [PULL 09/17] usb-uhci: clean up uhci resource when pci-uhci exit, Gerd Hoffmann, 2014/08/29
- Re: [Qemu-devel] [PULL 00/17] usb patch queue, Peter Maydell, 2014/08/29