Re: [Qemu-devel] [PATCH v6 04/15] target-tricore: Add initialization for translation and activate target

[Peter Maydell]

On 22 August 2014 17:52, Bastian Koppelmann
<address@hidden> wrote:
> Add tcg and cpu model initialization.
> Add gen_intermediate_code function.
> Activate target in configure and add softmmu config.
>
> Signed-off-by: Bastian Koppelmann <address@hidden>
>
> Reviewed-by: Richard Henderson <address@hidden>
> ---
>  configure                           |   5 ++
>  default-configs/tricore-softmmu.mak |   3 +
>  target-tricore/translate.c          | 165 
> ++++++++++++++++++++++++++++++++++++
>  3 files changed, 173 insertions(+)
>  create mode 100644 default-configs/tricore-softmmu.mak
>
> diff --git a/configure b/configure
> index 283c71c..009aac8 100755
> --- a/configure
> +++ b/configure
> @@ -5008,6 +5008,9 @@ case "$target_name" in
>      TARGET_BASE_ARCH=mips
>      echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak
>    ;;
> +  tricore)
> +    target_phys_bits=32

Why are you setting this variable? Nothing reads it.

> +  ;;
>    moxie)
>    ;;
>    or32)
> @@ -5205,6 +5208,8 @@ for i in $ARCH $TARGET_BASE_ARCH ; do
>      echo "CONFIG_MIPS_DIS=y"  >> $config_target_mak
>      echo "CONFIG_MIPS_DIS=y"  >> config-all-disas.mak
>    ;;
> +  tricore*)
> +  ;;

If you don't have a disassembler you don't need to put in an
empty case here.

>    moxie*)
>      echo "CONFIG_MOXIE_DIS=y"  >> $config_target_mak
>      echo "CONFIG_MOXIE_DIS=y"  >> config-all-disas.mak
> diff --git a/default-configs/tricore-softmmu.mak 
> b/default-configs/tricore-softmmu.mak
> new file mode 100644
> index 0000000..48ccd12
> --- /dev/null
> +++ b/default-configs/tricore-softmmu.mak
> @@ -0,0 +1,3 @@
> +include pci.mak

Do you really have PCI?

> +CONFIG_PFLASH_CFI01=y
> +CONFIG_SMC91C111=y

thanks
-- PMM