[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disa
|
From: |
Alexey Kardashevskiy |
|
Subject: |
Re: [Qemu-devel] [PATCH] ohci: Stop OHCI bus when PCI bus master is disabled |
|
Date: |
Thu, 11 Sep 2014 20:30:39 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 |
On 09/11/2014 08:15 PM, Gerd Hoffmann wrote:
> Hi,
>
>> To be precise, it is kdump.
>
> Ok, kdump is a different story, radically turn off all DMA is reasonable
> in that case, normal driver shutdown might be unreliable after panic and
> it also changes system state too much for a useful dump.
>
> ohci (and probably others too, but without spamming the log) throwing
> dma errors then is normal fallout though. kdump kernel should be able
> to bring the device back online after such an error, with your patch
> applied you can't test that with qemu any more ...
>
>>> Independant of that we can move the ohci error logging to tracepoints,
>>> so ohci emulation is silent by default.
>>
>> That is the other way to go, yes.
>
> Lets do it this way please.
Yep, no problem, I'll make a small patch.
Another question - I noticed that XHCI migration is broken in quite recent
upstream QEMU, smells like memory corruption. Is it just me or just PPC or
is it known issue?
--
Alexey