Re: [Qemu-devel] [PATCH 00/10] Implement ARM architectural watchpoints

[Peter Maydell]

On 29 August 2014 17:49, Richard Henderson <address@hidden> wrote:
> On 08/29/2014 04:21 AM, Peter Maydell wrote:
>> Peter Maydell (10):
>>   exec.c: Relax restrictions on watchpoint length and alignment
>>   exec.c: Provide full set of dummy wp remove functions in user-mode
>>   exec.c: Record watchpoint fault address and direction
>>   cpu-exec: Make debug_excp_handler a QOM CPU method
>>   target-arm: Implement setting of watchpoints
>>   target-arm: Move extended_addresses_enabled() to internals.h
>>   target-arm: Implement handling of fired watchpoints
>>   target-arm: Set DBGDSCR.MOE for debug exceptions taken to AArch32
>>   target-arm: Remove comment about MDSCR_EL1 being dummy implementation
>>   target-arm: Implement minimal DBGVCR, OSDLR_EL1, MDCCSR_EL0
>
> Patches 1-3:
> Reviewed-by: Richard Henderson <address@hidden>
>
> The rest I looked through and only saw one funny bit.
> In particular I didn't match up the implementation to the ARM.

Thanks. In the absence of further review from anybody
else I'm going to fix up the minor bug you spotted in
patch 5 and apply to target-arm.next.

-- PMM