[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_u
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union |
|
Date: |
Fri, 12 Sep 2014 17:39:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 12/09/2014 17:34, Michael Roth ha scritto:
>
> { 'union': 'UserDefUnion',
> 'base': 'UserDefZero',
> 'data': { 'a' : 'int', 'b' : 'UserDefB' } }
>
> If UserDefUnion.a is 0, UserDefUnion.data will cast it to a NULL value and
> cause the output visitor to bail, when really it should just be left to
> continue on serializing the integer.
In the case of dealloc, that'd be okay because the dealloc visit would
do nothing for KIND_A, right?
Paolo
- [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types, Michael Roth, 2014/09/11
- [Qemu-devel] [PATCH 2/3] qapi: dealloc visitor, implement visit_start_union, Michael Roth, 2014/09/11
- [Qemu-devel] [PATCH 3/3] tests: add QMP input visitor test for unions with no discriminator, Michael Roth, 2014/09/11
- [Qemu-devel] [PATCH 1/3] qapi: add visit_start_union and visit_end_union, Michael Roth, 2014/09/11
- [Qemu-devel] [PATCH 4/3] qemu-iotests: Test missing "driver" key for blockdev-add, Fam Zheng, 2014/09/11
- Re: [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types, Fam Zheng, 2014/09/11