Re: [Qemu-devel] [PULL 00/12] pci, pc, virtio, misc bugfixes

[Michael Roth]

Quoting Michael S. Tsirkin (2014-09-16 09:52:25)
> On Tue, Sep 16, 2014 at 04:07:35PM +0200, Paolo Bonzini wrote:
> > Il 16/09/2014 16:43, Michael S. Tsirkin ha scritto:
> > >> > 
> > >> > /root/qemu/tests/test-qdev-global-props.c: In function 
> > >> > ‘test_static_prop’:
> > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: implicit
> > >> > declaration of function ‘g_test_trap_subprocess’
> > >> > [-Werror=implicit-function-declaration]
> > >> > /root/qemu/tests/test-qdev-global-props.c:80:5: error: nested extern
> > >> > declaration of ‘g_test_trap_subprocess’ [-Werror=nested-externs]
> > >> > 
> > >> > This function was only added in glib 2.38, and our
> > >> > minimum version is 2.12.
> > >> > 
> > >> > thanks
> > >> > -- PMM
> > > The following should help?
> > > 
> > > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > 
> > We can still run a smaller suite of tests if subprocesses are not
> > available.  That's a better option, and doesn't require build system tests.
> > 
> > Paolo
> 
> Not sure I understand. Patch?

Maybe wrapping the test cases that depend on subprocesses with:

#if !GLIB_CHECK_VERSION(2, 38, 0)
    g_test_add(...)
#endif

?

If there's still some discussion to be had around the qdev stuff would you
consider sending a v2 without them? I'd like to make sure these are in before
the slirp CVE fix goes upstream so we can cut the 2.1.2 release soon after.