[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for un
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator |
Date: |
Thu, 18 Sep 2014 15:19:29 -0500 |
User-agent: |
alot/0.3.4 |
Quoting Eric Blake (2014-09-17 17:33:36)
> On 09/17/2014 03:32 PM, Michael Roth wrote:
> > This more of an exercise of the dealloc visitor, where it may
>
> s/This more/This is more/
>
> > erroneously use an uninitialized discriminator field as indication
> > that union fields corresponding to that discriminator field/type are
> > present, which can lead to attempts to free random chunks of heap
> > memory.
> >
> > Cc: address@hidden
> > Reviewed-by: Eric Blake <address@hidden>
> > Reviewed-by: Paolo Bonzini <address@hidden>
> > Signed-off-by: Michael Roth <address@hidden>
> > ---
> > tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
> > tests/qapi-schema/qapi-schema-test.out | 3 +++
> > tests/test-qmp-input-strict.c | 17 +++++++++++++++++
> > 3 files changed, 30 insertions(+)
> >
>
> R-b still stands.
Thanks, will send a v3 in a moment just to keep things clean.
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org