Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

[Gonglei (Arei)]

> From: Michael S. Tsirkin [mailto:address@hidden
> Sent: Monday, September 22, 2014 4:34 PM
> Subject: Re: [PATCH 0/3] Fix confused output for alias properties
> 
> On Mon, Sep 15, 2014 at 10:44:36PM +0800, address@hidden wrote:
> > From: Gonglei <address@hidden>
> >
> > At present, people have no way to know they should
> > have a specific format for alias properties.
> >
> >  Example:
> >
> > before output:
> >
> > virtio-blk-pci.physical_block_size=uint16
> > virtio-blk-pci.logical_block_size=uint16
> > virtio-blk-pci.drive=str
> >
> > after output applied this patch series:
> >
> > virtio-blk-pci.physical_block_size=blocksize
> > virtio-blk-pci.logical_block_size=blocksize
> > virtio-blk-pci.drive=drive
> >
> > Gonglei (3):
> >   qom: add error handler for object alias property
> >   qom: add target object poniter for alias property in ObjectProperty
> >   qmp: print real legacy_name for alias property
> >
> >  include/qom/object.h |  3 +++
> >  qmp.c                | 68
> ++++++++++++++++++++++++++++++++++++----------------
> >  qom/object.c         | 10 +++++++-
> >  3 files changed, 59 insertions(+), 22 deletions(-)
> 
> Basically this patch brings back historical HMP behaviour.
> As far as I could tell, it wasn't changed intentionally.
> So how about applying this first and then making more
> changes on top if required?
> 
I agree with you because the below virtio patch series is
somewhat of relying on this. (Please apply v2 if possible)

 [PATCH v2 0/9] virtio: fix virtio child recount in transports

What's your opinion, Paolo?  Thanks!

Best regards,
-Gonglei